Preview

Description

fixes following issues from #3124:

• Remove mobile-lg:grid-gap-0 from usa-footer__address > .grid-row.grid-gap on
  .usa-footer--slim

• Set display: inline-block to .usa-footer__contact-info on .usa-footer--slim vs default

We might not even need display: inline-block to be set at all.

• Fix big carets on collapsible items in .usa-footer--big

This was a big change, I ended up using a pseudoelement (instead of tweaking the background sizes/positioning) to get the sizing right. This approach was tested and worked in IE11 as well.

I chose to go this route because:

1. It saves us from nudging the spacing on collapsed vs expanded.
2. Keeps assets untouched

Now it depends on .usa-footer__primary-content--collapsible and .usa-footer__primary-content--collapsible.hidden. That way the arrow isn't added just because it's from the --big variation.

• Use auto for default footer link spacing @desktop to improve horizontal spacing

TODO:

• Big footer should be able to accept nav items that don't contain sub-items, just as the primary nav can be a combination of simple links and links that trigger menus.

This seems like it's own task? Could use more detail so we don't have unintended consequences.

• .usa-footer__logo-img needs an explicit width: 100%set

Wasn't seeing any issues with or without this.

• Follow the 18F Front End Coding Style Guide and Accessibility Guide.
• Run npm test and make sure the tests for the files you have changed have passed.
• Run your code through HTML_CodeSniffer and make sure it’s error free.
• [] Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.